Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix query parameter stripping in
fintoc.paginator.requestwhen fetching subsequent pages, preventing infinite loops in paginated resource generators under modernhttpxversions.Details
In
fintoc/paginator.py:params: dict = {}andheaders: dict = {}withNone.params=params or Noneintohttpx.Request, ensuring that existing query parameters in the target URL (such aspage=2provided by the Link header innext) are preserved rather than overwritten by an empty parameter mapping.link_headersvariable inrequest()to prevent shadowing the input argumentheaders.tests/test_paginator.pyensuring thatrequest()andpaginate()preserve query parameters across page transitions.Release notes